Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill Sheriff's Locker & Move SR Access config to their locker. #2819

Merged
merged 4 commits into from
Feb 8, 2025

Conversation

BramvanZijp
Copy link
Contributor

@BramvanZijp BramvanZijp commented Jan 31, 2025

About the PR

Filled the Sheriff's Locker on the NFSD Outpost (ID Card, Cuff Box, Demag, Access Config, etc.)
Moved the SR's Access Config from their bag to their locker.

EDIT: Access config is in the PTechs now, not locker.

Why / Balance

Firstly, currently if an SR is not ingame, no access configurator exists, which is a problem if needed by for example the DoC or the Sheriff.
Also, the sheriff used to get a few things in their locker, including the demag, but now they just don't. With this PR they get a demag, which is arguably more important for them then for the SR, alongside an access configurator for if they want to change NFSD Accesses (Add an armory lock to a bought armory crate, make certain areas on ships require higher access, etc.) Alongside some misc things such as a cuff box, comms console board, nfsd medal case, etc.

Also sidenote, yes I know that there is now an nfsd medal case on the Sheriff's desk and in their locker, but I feel like having extras doesn't hurt, for example if 2 civillians both deserve one of the civ medals.

How to test

Spawn as SR, Check the lockers for both Sheriff and SR.

Requirements

Changelog
🆑 BramvanZijp

  • add: Added several items to the Sheriff's Locker, including a Demag.
  • add: The PTech and NFSD PTech now both have 2 access configurators.
  • remove: The Station Representative no longer spawns with an access configurator in their bag.

@BramvanZijp
Copy link
Contributor Author

Requested changes applied.

@BramvanZijp BramvanZijp requested a review from dvir001 February 1, 2025 11:32
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Feb 1, 2025
@github-actions github-actions bot added the YML label Feb 8, 2025
@BramvanZijp BramvanZijp requested a review from dvir001 February 8, 2025 18:31
@whatston3 whatston3 merged commit 96573b6 into new-frontiers-14:master Feb 8, 2025
13 checks passed
FrontierATC added a commit that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants